add null check and fallback to document.getSelection to handle firefo… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x 45.7.0 iframe.windowContent.getSelection() returning null
|
This doesn't actually work for me on Firefox. I found a difference approach that I confirmed works on Firefox, Chrome, Safari, Brave, and Edge. So that's what I released as 1.2.0. |
|
Awesome, thanks you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On firefox 45.7.0
win.contentWindow.getSelection()returns call causing two issue in clipboard-copy:selection.removeAllRanges()outside of thetry-catchblock throws aTypeErrorand theiframeis never removed from the document, causing a spooky contentless-border to appear!The fix for this seems to be a null check on the return of
win.contentWindow.getSelectionand falling back todocument.getSelectionif the check check succeeds.I checked if replacing
win.contentWindow.getSelectionwithdocument.getSelectionsucceeds in all cases, but it fails to copy the desired contents in at least chrome 56.0.2924.87.This fix passes all tests, adds a line, and bumps the byte count by approximately 59 bytes.